Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Update location permission reqs for iOS #217

Merged
merged 4 commits into from
Jun 12, 2019
Merged

Update location permission reqs for iOS #217

merged 4 commits into from
Jun 12, 2019

Conversation

@rynop
Copy link
Contributor

@rynop rynop commented May 16, 2019

NSLocationAlwaysUsageDescription deprecated, use NSLocationAlwaysAndWhenInUseUsageDescription.

NSLocationUsageDescription is a macOS key.

@rynop
Update location permission reqs for iOS
5a720f5 
NSLocationAlwaysUsageDescription deprecated, use NSLocationAlwaysAndWhenInUseUsageDescription.

NSLocationUsageDescription is a macOS key.
@cla-bot
Copy link

cla-bot bot commented May 16, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @rynop.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@ghost ghost added the new PR label May 16, 2019
@cla-bot cla-bot bot removed the new PR label May 16, 2019
@rynop
Copy link
Contributor Author

rynop commented May 16, 2019

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label May 16, 2019
@cla-bot
Copy link

cla-bot bot commented May 16, 2019

The cla-bot has been summoned, and re-checked this pull request!

VladimirAmiorkov
VladimirAmiorkov suggested changes May 27, 2019
View reviewed changes
Copy link
Contributor

@VladimirAmiorkov VladimirAmiorkov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this plugin is being used in iOS version lower than 11.0 we need to make sure that those users know what the appropriate settings are. Can you simply add the new API side by side to the old one and write which one for which version of iOS is usable:

@Prefix1802 Prefix1802 mentioned this pull request Jun 9, 2019
Closed
@Prefix1802
Copy link

Prefix1802 commented Jun 9, 2019

Can someone please fix this? Would be very much appreciated. :)

@rynop
Copy link
Contributor Author

rynop commented Jun 10, 2019

@VladimirAmiorkov done. thanks.

@elena-p
Copy link
Contributor

elena-p commented Jun 12, 2019

run ci

@elena-p elena-p merged commit 1389c45 into NativeScript:master Jun 12, 2019
@rynop rynop deleted the patch-1 branch June 12, 2019 13:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@VladimirAmiorkov VladimirAmiorkov VladimirAmiorkov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rynop @Prefix1802 @elena-p @VladimirAmiorkov